389645 - bugfixes for bonsaipoller

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Axel Hecht [:Pike]]

Attachment: default to empty log msg, create files array once per <ci>

There are some nits that make bonsaipoller do bad things. It breaks on empty check-in comments (happens in l10n, sadly), and the list of files is wrong if there are multiple <ci>'s in one bonsai query.

Patch is attached.

I didn't fix the major bug yet, and that is, bonsaipoller blocking all of buildbot if bonsai is stalling. I'll do a patch similar to the one that I did for tinderboxpoller in a second round.

This code is in production on the l10n server, http://l10n.mozilla.org/buildbot/.

Ben, why do we add the version number to the files in bonsaipoller in the first place?

Comment 1

[[e-mail] (:bhearsum)]

Comment on attachment 273949 [details] [diff] [review]
default to empty log msg, create files array once per <ci>

Looks good. Can you send this upstream to buildbot.net too?

Because each file can have a different revision number we can't use the 'revision' property of the Change object. That's why it is appended to each file.

Thanks for the patch!

Comment 2

[Axel Hecht [:Pike]]

FIXED, filed http://buildbot.net/trac/ticket/61 to get the changes upstream.

Comment 3

[Reed Loden [:reed]]

(In reply to comment #0)
> I didn't fix the major bug yet, and that is, bonsaipoller blocking all of
> buildbot if bonsai is stalling. I'll do a patch similar to the one that I did
> for tinderboxpoller in a second round.

This happened to the unit test buildbots last night when bonsai was having problems.