389670 - References in SVG break in XBL bindings stored in a separate file

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Attachment: testcase showing references in inline bindings work

References in SVG content in XBL bindings that are stored in a separate file (not in the bound document) don't work. If the binding is moved inline into the document containing the bound elements then things work fine.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: external XBL binding for the next testcase

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: testcase showing references in external bindings are broken

Comment 3

[Jonathan Watt [:jwatt]]

Not the same issue, but it seems that in FF2 SVG in a binding can reference elements in the _bound_ document, but now in trunk that's no longer the case. Is that much deliberate Jonas?

Comment 4

[Olivier]

I'm just adding that neither of the two test cases are working in FFox2 - while on the other hand, references to gradients defined outside the xbl (eg: in another svg island, in the main document) used to work with FF2 and are no longer working on trunk (trunk apparently has the expected behavior on this).

Comment 5

[Robert Longson [:longsonr]]

(In reply to comment #3)
> Not the same issue, but it seems that in FF2 SVG in a binding can reference
> elements in the _bound_ document, but now in trunk that's no longer the case.
> Is that much deliberate Jonas?
> 

That's bug 387466 isn't it.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yes, looks like it is. As far as I know this isn't deliberate.

Comment 7

[Robert Longson [:longsonr]]

I think I fixed this with the patch in bug 387466.

Comment 8

[Jonathan Watt [:jwatt]]

This bug is broken in 2007-11-25-05-trunk and fixed in 2007-11-26-05-trunk, so it sure looks like it. Thanks Robert!

Comment 9

[Jonathan Watt [:jwatt]]

I checked in the following reftests:

reftests/svg/moz-only/xbl-basic-01.svg
reftests/svg/moz-only/xbl-basic-02.svg
reftests/svg/moz-only/xbl-grad-ref--grad-in-binding-01.svg
reftests/svg/moz-only/xbl-grad-ref--grad-in-binding-02.svg
reftests/svg/moz-only/xbl-grad-ref--grad-in-bound-01.svg
reftests/svg/moz-only/xbl-grad-ref--grad-in-bound-02.svg
reftests/svg/moz-only/xbl-grad-ref--grad-in-resources-01.svg
reftests/svg/moz-only/xbl-grad-ref--grad-in-resources-02.svg