389675 - [SeaMonkey port] Tab drag and drop indicator (arrow) only works after first drag of a tab

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

See bug 338302 comment 54...

{{{
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a7pre)
Gecko/200707251717 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Bug still there, in SeaMonkey.

I wonder if the following file(s) should be fixed too ?
{{
/themes/classic/navigator/mac/tabbrowser.css,
    * line 92 -- .tab-drop-indicator-bar {
/themes/classic/navigator/win/tabbrowser.css,
    * line 54 -- .tab-drop-indicator-bar {
/themes/modern/navigator/tabbrowser.css,
    * line 108 -- .tab-drop-indicator-bar {
}}
}}}

Comment 1

[[e-mail]]

Attachment: Proposed patch

Since we intelligently put the half-indicator-width measurement in the skin where it belongs we can simply switch from hidden to collapsed.

Comment 2

[jag (Peter Annema)]

Comment on attachment 275244 [details] [diff] [review]
Proposed patch

r/sr=jag though I still wonder what changed. This stuff used to work just fine. Why does an async load of the mouse cursor image not go through until the drag is done?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> (From update of attachment 275244 [details] [diff] [review])
> r/sr=jag though I still wonder what changed.

Bug 338302 comment 2 says "nsIThreadManager".

Comment 4

[[e-mail]]

Fix checked in.

Comment 5

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007092402 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007092502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

V.Fixed between these two nighlies.

Comment 6

[Serge Gautherie (:sgautherie)]

Should this patch be backed out, now that bug 389931 (which fixed bug 326273 regression) is fixed ?

Comment 7

[[e-mail]]

(In reply to comment #6)
>Should this patch be backed out, now that bug 389931 is fixed ?
We could do, I guess... jag, any thoughts?

Comment 8

[jag (Peter Annema)]

Unless there's a good reason to use hidden instead of collapsed, let's spend our energy elsewhere.