389719 - prefetch-related leak loading firefox google start page

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When I start the browser with http://www.google.com/firefox as the home page, I leak a bunch of objects.  It seems like the root of the leak is a prefetch node and the prefetch service, although I haven't looked into it too closely.  The prefetch node is holding on to an nsHttpChannel (should it still be holding on to one at shutdown?), which it turn owns the nsHttpHandler, which in turn leaks a bunch of other services.

Steps to reproduce:
 1. export XPCOM_MEM_LEAK_LOG=leak.log
 2. ./firefox http://www.google.com/firefox
 3. close the browser window that comes up
 4. look at leak.log to see what objects leaked

Comment 1

[Benjamin Smedberg]

biesi, can you look at this?

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

OK, this bug requires that the prefetched resource is already in the cache. HTTP doesn't release the notification callbacks in that case.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 279133 [details] [diff] [review]
patch

Nice catch!

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsHttpChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v  <--  nsHttpChannel.cpp
new revision: 1.320; previous revision: 1.319
done