389811 - Japan Holidays ics file update

Status: VERIFIED FIXED

(Calendar :: Website, defect)

Description

[Atsushi Sakai]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070518 Minefield/3.0a5pre
Build Identifier: 

The current Japanese holidays ics file has following problem:

1. It includes neither substitute holidays (振替休日 in Japanese) nor holidays between national holidays (so called 国民の休日 in Japanese).
2. The date of Vernal Equinox Day and Autumnal Equinox Day is sometimes wrong.
3. Japanese name of Children's Day "子供の日" is wrong. It is "こどもの日" correctly.

Updated ics file will be attached.

Reproducible: Always

Comment 1

[Atsushi Sakai]

Attachment: Japan Holidays in Calendar (.ics) Format updated

Comment 2

[Shinya Kuribayashi]

I looked closely into the diff between the previous JapanHolidays.ics and the above one, and I want to say that Atushi's ics is pretty in good shape. Eespecially, the workarounds for Vernal Equinox Day and Autumnal Equinox Day is *very* nice!

With this ics everybody japanese are happy at least for 10 years. I hope this version checked in soon.

P.S. this isn't mentioned in report, some needless trailing asterisk(*)s in SUMMARY are also cleaned up. thanks for your work.

Comment 3

[Simon Paquet [:sipaq]]

File checked in. Thanks for your contribution and please set an appointment to send me an update in time :-)

Comment 4

[Simon Paquet [:sipaq]]

Atsushi, Shinya,

I'm currently in the process of adding the period (that the holiday calendar covers) to all holiday calendars. See http://www.mozilla.org/projects/calendar/holidays.html

From comment 2, I take it, that the file that Atsushi submitted is valid for some more years. Can you please tell me when it expires? Thanks!

Comment 5

[Atsushi Sakai]

(In reply to comment #4)
> Can you please tell me when it expires? Thanks!

It might be changed by the new law in the future,
but it's valid for 2007-2022 under the latest law.
Thanks.

Comment 6

[Simon Paquet [:sipaq]]

(In reply to comment #5)
> It might be changed by the new law in the future, 
> but it's valid for 2007-2022 under the latest law.

Thanks Atsushi!
I've added that to http://www.mozilla.org/projects/calendar/holidays.html