Closed Bug 389815 Opened 17 years ago Closed 16 years ago

Can't edit shared queries if you can't run them

Categories

(Bugzilla :: User Accounts, defect, P4)

Product:
Bugzilla
Component:
User Accounts
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.2

People

(Reporter: timeless, Assigned: timeless)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

patch I check in
1.30 KB, patch
LpSolit
: review+
Details | Diff | Splinter Review 
paul and I both have queries that crash when we run them. We've shared them (hi as "bugs with my patches2", mine as "patched").

There's no way for people to find out why our queries crash. Even though if they were us, they could click a fancy edit link at the top of the page.
Severity: enhancement → minor
OS: Mac OS X → All
Priority: -- → P4
Hardware: Macintosh → All
Summary: can't edit shared queries → Can't edit shared queries if you can't run them
Attached patch feature parity? (obsolete) — — Splinter Review 
Assignee: user-accounts → timeless
Status: NEW → ASSIGNED

        Attachment #274401 -
        Flags: review?(wicked)

    
    

    
  
Comment on attachment 274401 [details] [diff] [review]
feature parity?

>+          <a href="query.cgi?[% q.edit_link FILTER html %]&amp;known_name=
>+                   [% q.name FILTER url_quote %]_
>+                   [% q.user.id FILTER url_quote %]">Edit</a>

Having the user ID appended to the query name is not very helpful. If your goal is to avoid overriding an existing query with the same name, you should use the user nick instead, i.e. "q.user.nick". r=LpSolit with either the user ID removed or replaced by its nick.

        Attachment #274401 -
        Flags: review?(wicked) → review+

    
  
Flags: approval+
Target Milestone: --- → Bugzilla 3.2

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch I check in
        — 
          — Splinter Review
      

    


  

        Attachment #274401 -
        Attachment is obsolete: true

        Attachment #302713 -
        Flags: review+

    
    

    
  
Checking in template/en/default/account/prefs/saved-searches.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/saved-searches.html.tmpl,v  <--  saved-searches.html.tmpl
new revision: 1.18; previous revision: 1.17
done

Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: