Status

defect
--
minor
RESOLVED FIXED
12 years ago
a year ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Other Branch

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

12 years ago
Posted patch new .hgignore (obsolete) — Splinter Review
This patch switches to glob notation, which I think is a little more readable; adds comments; and eliminates all the remaining cruft from "hg status" except for one file:  security/manager/.nss.checkout, which I didn't add because I don't know what creates it.
Attachment #274152 - Flags: review?(benjamin)
Assignee

Updated

12 years ago
Status: NEW → ASSIGNED

Comment 1

12 years ago
Comment on attachment 274152 [details] [diff] [review]
new .hgignore

I think the intent of the changes is fine, but I prefer regex syntax to glob.
Attachment #274152 - Flags: review?(benjamin) → review-
Assignee

Comment 2

12 years ago
Glob syntax was designed especially for matching filenames.  It's the syntax used by the shell and by Unix find.  So when most people think about matching filenames, they think in globs.

Glob is less powerful than regex, therefore better.

- You don't have to remember to escape dots.
- You don't have to remember to anchor patterns with ^$.
- You don't have to write [^/]* to say "a single path segment".
- You don't have to know the details of Python regexps, as opposed to grep regexps, Emacs regexps, etc.
- So the globs are easier for the average guy to read and write, and mistakes are less likely.

None of our current patterns require regex.  But you can use glob and regex in the same .hgignore file, should the need arise.
Assignee

Comment 3

12 years ago
Well, how about this then?  :)
Assignee: nobody → jorendorff
Attachment #274152 - Attachment is obsolete: true
Assignee

Updated

12 years ago
Attachment #280647 - Flags: review?(benjamin)

Updated

12 years ago
Attachment #280647 - Flags: review?(benjamin) → review+
Assignee

Updated

12 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Assignee

Comment 4

12 years ago
Pushed changeset 45182e442e21 to mozilla-central.

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.