389835 - Various issues when changing several bugs at once

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

Bug::check_status_transition() should probably use Status::can_change_to(), or I simply have to fix check_status_transition() to allow FOO -> FOO transitions.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Changing several bugs at once is pretty broken on tip. This patch should restore the feature completely.

Comment 2

[Frédéric Buclin]

Not only mass-change is broken when at least one bug keeps the same status, as badly explained in comment 0, but closing a bug also fails to set the resolution correctly due to a wrong name attribute for the <select> field (all <select> fields had the same incorrect name).

This patch also fixes the UI for mass-change to avoid confusion. I was myself pretty confused when the buglist includes closed bugs and it took me some time to track the problem (which was only a problem in the UI, the back-end was mostly fine).

Comment 3

[Max Kanat-Alexander]

Comment on attachment 274204 [details] [diff] [review]
patch, v1

Sure, this looks fine. r=mkanat by inspection.

Comment 4

[Frédéric Buclin]

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.360; previous revision: 1.359
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.381; previous revision: 1.380
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.195; previous revision: 1.194
done
Checking in Bugzilla/Status.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Status.pm,v  <--  Status.pm
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.223; previous revision: 1.222
done
Checking in template/en/default/list/edit-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v  <--  edit-multiple.html.tmpl
new revision: 1.44; previous revision: 1.43
done