Closed Bug 389867 Opened 13 years ago Closed 12 years ago

Array indexing error in ReadCurve (mozilla/modules/lcms/src/cmsio1.c)

Categories

(Core Graveyard :: GFX, defect)

Product:
Core Graveyard
Component:
GFX
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9beta3

People

(Reporter: kherron+mozilla, Assigned: ehsan)

References

(
URL
)

Details

(Keywords: coverity)

Attachments

(1 file)

Patch (v1)
1.65 KB, patch
pavlov
: review+
pavlov
: superreview+
mtschrep
: approval1.9+
Details | Diff | Splinter Review 
This is coverity ID #1233. Please see the sample URL. At line 934, ParamsByType[] has valid indices of 0..4. But the bounds checking on Type allows values 0..5. So a type of 5 will access memory beyond the end of ParamsByType.
Keywords: coverity
Taking over...
Assignee: nobody → ehsan.akhgari
Target Milestone: --- → mozilla1.9 M11
Attached patch Patch (v1) — — Splinter Review 
Trivial patch
Attachment #295215 - Flags: superreview?
Attachment #295215 - Flags: review?
Attachment #295215 - Flags: superreview?(pavlov)
Attachment #295215 - Flags: superreview?
Attachment #295215 - Flags: review?(benjamin)
Attachment #295215 - Flags: review?
Comment on attachment 295215 [details] [diff] [review]
Patch (v1)

I am not a peer of this code, and don't know anything about it.
Attachment #295215 - Flags: review?(benjamin)
Attachment #295215 - Flags: review?(pavlov)
Status: NEW → ASSIGNED
Marti: does this look right?
Yes, that would be enough. Thanks.
Attachment #295215 - Flags: superreview?(pavlov)
Attachment #295215 - Flags: superreview+
Attachment #295215 - Flags: review?(pavlov)
Attachment #295215 - Flags: review+
Keywords: checkin-needed
This is part of the build... needs approval.
Keywords: checkin-needed
Attachment #295215 - Flags: approval1.9?
Attachment #295215 - Flags: approval1.9? → approval1.9+
Checking in modules/lcms/src/cmsio1.c;
/cvsroot/mozilla/modules/lcms/src/cmsio1.c,v  <--  cmsio1.c
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.