Closed Bug 389867 Opened 13 years ago Closed 12 years ago
Array indexing error in Read
Curve (mozilla/modules/lcms/src/cmsio1 .c)
This is coverity ID #1233. Please see the sample URL. At line 934, ParamsByType has valid indices of 0..4. But the bounds checking on Type allows values 0..5. So a type of 5 will access memory beyond the end of ParamsByType.
Coverity ID 1234 is the same issue later in the file: <http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/modules/lcms/src/cmsio1.c&rev=1.1&mark=1024,1036,1043#1022>
Assignee: nobody → ehsan.akhgari
Target Milestone: --- → mozilla1.9 M11
Comment on attachment 295215 [details] [diff] [review] Patch (v1) I am not a peer of this code, and don't know anything about it.
Marti: does this look right?
Yes, that would be enough. Thanks.
This is part of the build... needs approval.
Checking in modules/lcms/src/cmsio1.c; /cvsroot/mozilla/modules/lcms/src/cmsio1.c,v <-- cmsio1.c new revision: 1.3; previous revision: 1.2 done
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.