Why: -Bsymbolic causes the linker to resolve as many symbols as possible at link time, so references from a class to its indirection table (for example) are not resolved to a separate shared object. This has the additional advantage of making loading faster. Linux does this already, and now that I tested building with it I want it ASAP.
Comment on attachment 274284 [details] [diff] [review] add -Bsymbolic, and remove weird BeOS-comment (1.8 branch) r? Simple change most other platforms have this so review should be no-brainer. Would like this checked in on 1.8 branch as well as trunk. What needs to be done?
Attachment #274284 - Flags: review?(benjamin)
Comment on attachment 274284 [details] [diff] [review] add -Bsymbolic, and remove weird BeOS-comment (1.8 branch) To request approval for the 1.8.1 branch, set "approval220.127.116.11?".
Attachment #274284 - Flags: review?(benjamin) → review+
I've successfully applied the patch and built Firefox 18.104.22.168pre (22.214.171.124) and can see no regressions.
Any chance of 126.96.36.199 as requested?
Status: NEW → ASSIGNED
Comment on attachment 274284 [details] [diff] [review] add -Bsymbolic, and remove weird BeOS-comment (1.8 branch) approved for 188.8.131.52, a=dveditz for release-drivers
Attachment #274284 - Flags: approval184.108.40.206? → approval220.127.116.11+
thank you, Daniel! Sergei, do you have the ability to commit this change?
Will try ASAP (this weekend probably)
Checking in mozilla/config/rules.mk; /cvsroot/mozilla/config/rules.mk,v <-- rules.mk new revision: 3.487.2.8; previous revision: 3.487.2.7 done
QA Contact: build-config → thesuckiestemail
Sergei, was that on trunk? I'd like it in the branch for Firefox 18.104.22.168, so we can release a kick ass version of it :) Can't see it on either branch in LXR yet though...
2 tqh both checkout and checkin command lines included -r MOZILLA_1_8_BRANCH (though, for ci it is not needed AFAIK after proper co). LXR and anonymous cvs-mirrors may lag. Will see tomorrow, if I made some big mistake or you are bit impatient:)
I updated using the branch tag today - the checkin was in the branch. Thanks, Sergei! tqh, I think you can mark the status as "fixed". Thanks for this great build change.
I think we should land it on trunk as well.
(In reply to comment #13) > I think we should land it on trunk as well. > A good idea, just in case anyone overcomes all the dependency problems and manages to get a working trunk build someday.
tqh, can you help us verify this fix in FF 2008rc2?
(In reply to comment #15) > tqh, can you help us verify this fix in FF 2008rc2? > I can verify the fix is in 22.214.171.124 and working. Thanks, juan!
Assignee: nobody → doug
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.