389988 - showModalDialog should return null instead of throwing when blocked as an unwanted popup

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P4)

Description

[Michael Ventnor]

When the popup blocker blocks a modal dialog, it will return NS_ERROR_FAILURE rather than NS_OK, because showModalDialog doesn't tell OpenInternal to do the "JS fixups".

This means that an exception is thrown in Javascript. Bad.

We need to make a script-safe version of ShowModalDialog() like we did with Open(), so it will not throw if our popup blocker blocks it.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Untested but obvious patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

I think we should just pass PR_TRUE for aDoJSFixups.  I don't see what problems it would cause that can't also be caused by modal window.open...

I guess we can do that in a followup bug, though.  But make sure one is filed?

Comment 3

[Johnny Stenback (:jst)]

Blocking on making us match what IE does in these situations (which someone would need to check on).

Comment 4

[Jeff Walden [:Waldo]]

We can deal with the remaining issues in the followup bug; I'm not entirely sure why I didn't close this when I committed the fix, to be honest.

Comment 5

[Jeff Walden [:Waldo]]

Somehow I think I forgot to get a followup bug filed; that's bug 437361 now.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Maybe I was unclear.  I think this patch was the wrong thing to do: we _do_ want to throw some exceptions from here to the calling script if they happen down below, imo.