390021 - Remove old form fill hooks now that we've converted to satchel.

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Mark Banner (:standard8)]

Attachment: Remove the navigator overlay and the form fill prefs pane.

Bug 304309 has converted us to satchel. We should remove the old form fill options and dialogs as they are no longer necessary.

However as we're planning on moving to toolkit's password manager as well, I propose that we do the minimum and just remove the overlay commands for now. Once we've picked up toolkit's password manager, then we can disable the whole of wallet.

This means our testers don't get confused and we're doing the minimum of work necessary.

Comment 1

[Philip Chee]

Silly question, how do you access the Firefox form fill prefs and manager?

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> Silly question, how do you access the Firefox form fill prefs and manager?
> 
The Firefox form fill pref is on the privacy page under history. There is no manager for it. Firefox has no manager for the form fill because it works in a slightly different manner.

The pref is browser.formfill.enable, we still need to modify our preferences to provide that and probably a couple of other options.

Comment 3

[Robert Kaiser]

Umm, I hope the navigator overlay does not contain the password manager entries in the menus, we still need those...

Ah, and yes, we should file a bug on adding the formfill pref as a UI pref somewhere.

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> Umm, I hope the navigator overlay does not contain the password manager entries
> in the menus, we still need those...

That's the walletTasksOverlay that deals with those entries.

Comment 5

[Philip Chee]

> Ah, and yes, we should file a bug on adding the formfill pref as a UI pref
> somewhere.

Can't we just reuse the existing prefPane checkbox repointed to the new pref and remove the buttons (or comment them out) for "manage form data" and "manage sites"

Comment 6

[Philip Chee]

Making a note of this before I forget
<http://www.radebatz.net/mano/mozilla/extensions/formhistory/>

Comment 7

[Mark Banner (:standard8)]

(In reply to comment #5)
> > Ah, and yes, we should file a bug on adding the formfill pref as a UI pref
> > somewhere.
> 
> Can't we just reuse the existing prefPane checkbox repointed to the new pref
> and remove the buttons (or comment them out) for "manage form data" and "manage
> sites"

Yes and no. The problem is the current pref file resides in extensions/wallet and the next one will be in /suite. Additionally there's some other options that we may want to pick up from Firefox like clearing personal data. So I'd like to take a look at that before just doing this change. If we didn't have to move the code as well, I'd just do it, but because of the additional code move, I'd like to check out what we need first.

Comment 8

[Robert Kaiser]

Yes, the old pref panel goes away with wallet, as it lives there. I guess it's best to just write a new one in suite/ - it's not that hard, I think...
Anyways, a new bug for that would probably be a good idea - and it might be reasonable to make it dependent on bug 342087

Comment 9

[Mark Banner (:standard8)]

I've raised bug 390158 to cover the addition of the new pref to a preference pane.

The patch is now checked in, so this bug is fixed.

Comment 10

[[e-mail]]

Attachment: More form fill stuff

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 275252 [details] [diff] [review]
More form fill stuff

looks good, r=me.