390104 - about:config - button lacks padding on left and right

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

Attachment: screen shot

The text 'I understand and wish to continue' is nearly even with the border on both the left and right side.

Digging around, it appears that the padding on that button is controlled by a button.css file, linked from within config.css.
Comparing the button.css file that ships with Camino (in MacOS > chrome > embed.jar > skin > classic > global) is (completely) different from the equivalent file in Minefield builds. I remember Josh doing some work in that file for the new Aqua form controls).

That file, in Camino, specifies only 4px padding-left/padding-right and does something with transparent borders (the same way as Camino branch nearly) to shape up the (xul) button. But that doesn't work correctly with the new themed form controls.

Minefield fetches that button.css file from mozilla/toolkit/themes/pinstripe, whereas Camino fetches it from mozilla/themes/... (modern or classic) ? (in CVS).

The 'easy' way to fix this is to edit config.css for Camino. Just adjusting the padding in that file solves the issue here. But I'm not sure if that is  the 'correct' way...

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Hmm, if we're pulling that file from mozilla/themes, there goes my theory on bug 389140 :(

I'm leaning towards suggesting we ought to officially fork (e.g., camino/themes) all of those files that we "use" in some way....

Comment 2

[philippe (part-time)]

Actually, I'm not really sure that Camino pulls it from mozilla/themes. But that is the only location where I (ahem, Spotlight) found a similar button.css (by content and date last modified) file.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Tinderbox log reports "storing" three different "button.css" files, but it takes 5 times to do so :P  We use classic, so it's not the modern copy, obviously.

adding: skin/classic/communicator/button.css (stored 0%)
adding: skin/classic/global/button.css (stored 0%)
adding: skin/modern/communicator/button.css (stored 0%)
adding: skin/modern/global/button.css (stored 0%)
adding: skin/classic/global/button.css (stored 0%)

My guess our file is mozilla/themes/classic/global/mac/button.css, which is pretty out-of-date compared to the toolkit/themes/pinstripe copy....

Comment 4

[philippe (part-time)]

Yeah, most of those files are pretty old.
I looked at what SeaMonkey trunk uses, and that is the same button.css file as Minefield builds.
As you commented in bug 389140, it would probably better if Camino used the toolkit/themes/pinstripe/* files
(that would probably help improve some other XUL display issues).

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Fixed by my patch in bug 389140 (Camino part).