39020 - Widgets have borders

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Blake Ross]

Build ID: 2000051108

Most widgets now appear to have a thin, inset border around them.  visible in 
URL history dropdown arrow, in numerous places in the prefs dialog, and nearly 
everywhere else.

Comment 1

[R.K.Aa.]

on linux too. A psudo 3D look with hairy corners. Very appearant in ..Foopy.

Comment 2

[John Morrison]

So, it appears that a change to the calculation of -moz-border-radius
results in the change to the <button> appearance. (I initially thought
it was just more funky css from ben :-]).

Attaching a screenshot comparing the appearance of a simple <button>
style (based on what is in button.css): The left hand side is a May 11
win32 build, the right hand side is May 10. Top to bottom the four
buttons are:

              
 |  button                               |  button > .button-internal-box
-|---------------------------------------|--------------------------------
1| -moz-border-radius: 3px 2px 2px 3px;  |  border: 1px outset #CCCCCC;
2| -moz-border-radius: 0px 0px 0px 0px;  |  border: 1px outset #CCCCCC;
3| -moz-border-radius: 3px 2px 2px 3px;  |  border: 1px solid  #CCCCCC;
4| -moz-border-radius: 0px 0px 0px 0px;  |  border: 1px solid  #CCCCCC;
-|---------------------------------------|--------------------------------


 2 and 4 have the same appearance; 1 and 3 do not (with 1 being the standard
 set of styles for a button).

---
The XUL for this image is :

<?xml version="1.0"?> 

<?xml-stylesheet href="button.css" type="text/css"?>


<window xmlns:html="http://www.w3.org/TR/REC-html40"
	xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
	xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
	align="horizontal" style="padding-top:20px;">

    <box orient="vertical">
      <button value="Sample Text" />
      <button value="Sample Text" id="no-outer-radius" />
      <button value="Sample Text" id="inner-box-solid" />
      <button value="Sample Text" id="no-outer-radius-inner-box-solid" />
    </box>			      

</window>


---
The CSS for this image is :

  button {
      border              : 1px solid #000000;
      -moz-border-radius  : 3px 2px 2px 3px;
      margin              : 1px;
      background-color    : #CCCCCC;
  }
  button > .button-internal-box {
      border              : 1px outset #CCCCCC;
      padding             : 2px;
  }
  button#no-outer-radius {
      -moz-border-radius  : 0px 0px 0px 0px;
  }
  button#inner-box-solid > .button-internal-box {
      border              : 1px solid #CCCCCC;
  }
  button#no-outer-radius-inner-box-solid {
      -moz-border-radius  : 0px 0px 0px 0px;
  }
  button#no-outer-radius-inner-box-solid > .button-internal-box {
      border              : 1px solid #CCCCCC;
  }
    
---
Adding nsbeta2 for beta 2 consideration.   

Comment 3

[John Morrison]

Attachment: screenshot; LHS May 11 -- RHS May 10 -- buttons change in appearance

Comment 4

[John Morrison]

adding nsbeta2 keyword

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

don, was this caused by your rounding change checkin on May 10? I talked to 
evaughan and he seemed to think it was. 

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

*** Bug 39021 has been marked as a duplicate of this bug. ***

Comment 7

[dcone (gone)]

I had a fix in for some pixel thick framing.. somehow this is being called when 
buttons are asked to paint.  I took out this code.. but I have to find out why 
buttons are asking for 1 pixel lines to be painted. 

Comment 8

[Blake Ross]

vrfy fixed in new win98 build