390348 - empty atom must be pinned

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Igor Bukanov]

Attachment: fix v1

This is a regression from bug 389880. There when initializing emptyAtom I forgot to add ATOM_PINNED flag meaning that it can be GC-ed.

Comment 1

[Igor Bukanov]

Attachment: fix v2

The new version removes no longer necessary static forward of AtomizeHashedKey. What I have been thinking when writing overly complex and buggy initializer of emptyAtom?..

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 274659 [details] [diff] [review]
fix v2

I meant to go back and see why AtomizeHashedKey was prototyped early, but forgot. Sorry,

/be

Comment 3

[Igor Bukanov]

I checked in the patch from comment 1 to the trunk:

Checking in jsatom.c;
/cvsroot/mozilla/js/src/jsatom.c,v  <--  jsatom.c
new revision: 3.102; previous revision: 3.101
done

Comment 4

[Igor Bukanov]

I baked out the last patch to wait until the tree will be opened.

Checking in jsatom.c;
/cvsroot/mozilla/js/src/jsatom.c,v  <--  jsatom.c
new revision: 3.103; previous revision: 3.102
done

Comment 5

[Igor Bukanov]

This is a trunk regression fix.

Comment 6

[Igor Bukanov]

I checked in the patch from comment 1 to the trunk:

Checking in jsatom.c;
/cvsroot/mozilla/js/src/jsatom.c,v  <--  jsatom.c
new revision: 3.104; previous revision: 3.103
done

Comment 8

[Igor Bukanov]

Clearing blocking 1.9 ? flag as the bug was fixed based on 1.9 approval for the checked-in patch.