Closed
Bug 390361
Opened 17 years ago
Closed 17 years ago
Fix FF+XR builds to copy XR to make a complete package
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
(Whiteboard: [fixed in Firefox 3.1a1])
Attachments
(1 file)
4.64 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Currently when you do a FF+XR build you end up with two objdirs but it's really hard to actually *run* the build because the browser doesn't know where XR is (unless it's globally registered, which is unusual). This patch copies libxul-sdk/bin to the browser dist/bin/xulrunner directory and copies the stub to "firefox.exe". This won't quite get us to shippable FF+XR builds because I'll need to fix up the packaging manifests, but we're really close!
Attachment #274669 -
Flags: review?(ted.mielczarek)
Comment 1•17 years ago
|
||
Comment on attachment 274669 [details] [diff] [review] FF+XR packaging, rev. 1 >Index: browser/app/Makefile.in > ifeq ($(USE_SHORT_LIBNAME), 1) > PROGRAM = $(MOZ_APP_NAME)$(BIN_SUFFIX) >-else >+elsev Typo? >+ifdef LIBXUL_SDK >+libs:: >+ cp $(LIBXUL_DIST)/bin/xulrunner-stub$(BIN_SUFFIX) $(DIST)/bin/firefox$(BIN_SUFFIX) Does this do the right thing on Linux, where 'firefox' is a script and 'firefox-bin' is the binary? Looks good otherwise, r=me.
Attachment #274669 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 2•17 years ago
|
||
> Does this do the right thing on Linux, where 'firefox' is a script and
> 'firefox-bin' is the binary?
Yes, because in the FF-XR case it's not a script, it's the xulrunner-stub binary
Assignee | ||
Comment 3•17 years ago
|
||
Fixed on trunk. I'll file a followup on fixing the packaging manifests.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 4•14 years ago
|
||
Comment on attachment 274669 [details] [diff] [review] FF+XR packaging, rev. 1 http://hg.mozilla.org/mozilla-central/rev/bcd5a603eeaf
Comment 5•14 years ago
|
||
(In reply to comment #3) > I'll file a followup on fixing the packaging manifests. Could you add a dependency to that bug? Thanks.
Whiteboard: [fixed in Firefox 3.1a1]
Updated•14 years ago
|
Flags: in-testsuite-
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•