Closed Bug 390363 Opened 17 years ago Closed 17 years ago

ActionMonkey: Linux doesn't include -lpthread and -ldl

Categories

(Core :: JavaScript Engine, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: anemitz, Assigned: anemitz)

Details

Attachments

(1 file, 1 obsolete file)

g++ -o Linux_All_DBG.OBJ/js -Wall -Wno-format -MMD -fno-rtti -DGCC_OPT_BUG -g -DXP_UNIX -DSVR4 -DSYSV -D_BSD_SOURCE -DPOSIX_S
OURCE -DHAVE_LOCALTIME_R -DUNIX -DAVMPLUS_UNIX -DUSE_MMAP -DX86_LINUX -DDEBUG -DDEBUG_anemitz -DSOFT_ASSERTS -D__DEBUGGING__
-DEDITLINE -ILinux_All_DBG.OBJ -I../tamarin/MMgc Linux_All_DBG.OBJ/js.o Linux_All_DBG.OBJ/libjs.a -lm -L../tamarin/Linux_A
ll_DBG.OBJ -lMMgc \
editline/Linux_All_DBG.OBJ/libedit.a
../tamarin/Linux_All_DBG.OBJ/libMMgc.a(GC.o): In function `MMgc::GC::GetStackTop() const':
/home/anemitz/moz/am_3/js/tamarin/MMgc/GC.cpp:1477: undefined reference to `pthread_key_create'
/home/anemitz/moz/am_3/js/tamarin/MMgc/GC.cpp:1481: undefined reference to `pthread_getspecific'
/home/anemitz/moz/am_3/js/tamarin/MMgc/GC.cpp:1494: undefined reference to `pthread_getattr_np'
/home/anemitz/moz/am_3/js/tamarin/MMgc/GC.cpp:1504: undefined reference to `pthread_attr_getstack'
/home/anemitz/moz/am_3/js/tamarin/MMgc/GC.cpp:1511: undefined reference to `pthread_setspecific'
../tamarin/Linux_All_DBG.OBJ/libMMgc.a(GCHeapUnix.o): In function `MMgc::GetInfoFromPC(int, char*, int)':
/home/anemitz/moz/am_3/js/tamarin/MMgc/GCHeapUnix.cpp:309: undefined reference to `dladdr'
Attached patch Added lpthreads and ldl (obsolete) — Splinter Review
Attachment #274674 - Flags: review?(jorendorff)
Comment on attachment 274674 [details] [diff] [review]
Added lpthreads and ldl

diff -r f88d0888d16f js/src/config/Linux_All.mk
--- a/js/src/config/Linux_All.mk        Tue Jul 31 09:57:53 2007 -0400
+++ b/js/src/config/Linux_All.mk        Tue Jul 31 14:18:33 2007 -0700
@@ -77,7 +77,8 @@ endif

 GFX_ARCH = x

-OS_LIBS = -lm -lc
+OS_LIBS = -lm -lc
+OS_PROG_LIBS = -lpthread -ldl

 ASFLAGS += -x assembler-with-cpp
Attachment #274674 - Attachment is obsolete: true
Attachment #274674 - Flags: review?(jorendorff)
Attachment #274698 - Flags: review?(jorendorff)
Comment on attachment 274698 [details] [diff] [review]
added OS_PROG_LIBS

Looks fine, I'll check it in tomorrow morning (01 Aug 2007).

Btw, I wonder why Mercurial generated a diff for a line that didn't actually change.
Attachment #274698 - Flags: review?(jorendorff) → review+
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: