The XUL toolbar's "mode" attribute is not functional




12 years ago
11 years ago


(Reporter: emery.denuccio, Unassigned)


Firefox Tracking Flags

(Not tracked)



(1 attachment, 1 obsolete attachment)



12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20070725 Firefox/
Build Identifier: 

The "mode" attribute described in does not function because the styles do not exist in the global skin.

Reproducible: Always

Comment 1

12 years ago
Created attachment 275222 [details] [diff] [review]
Moves the styles for "mode" to a location where they won't be overridden.

This patch should fix it in all themes.

Comment 2

12 years ago
Created attachment 275225 [details] [diff] [review]
Fixes a small mistake in the previous patch

I accidentally left a line removal in the previous patch that doesn't apply to the bug. Sorry about that.
Attachment #275222 - Attachment is obsolete: true
Emery, is this patch ready for reviews?  If so, may I suggest mconnor or neil@parkway?

Comment 4

12 years ago
Neil looked at it before and, IIRC, although the patch is good and those style rules do just need to be in toolbarbutton.css instead of toolbar.css to avoid being overridden, he noticed some nasty workarounds wherein toolbar.css is imported after the global skin, effectively re-overriding the overridden styles. And he told me that I should remove all of those imports while I'm at it, making sure that it doesn't break Thunderbird which happens to be affected. I'll make the changes and ask Neil to review it again. Thanks for the reminder Alex.
You need to log in before you can comment on or make changes to this bug.