Closed Bug 390480 Opened 17 years ago Closed 17 years ago

change nsIAttribute so it can be used by extensions

Categories

(Core :: DOM: Core & HTML, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: aaronr, Assigned: aaronr)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Similar to bug 350747, I think that nsIAttribute should be usable by extensions.  In the case of XForms, we use nsIAtribute to put properties on some of our attributes just like we nsIContent to do the same with our elements.  However, the constructor for nsIAttribute constructs itself using a constructor that isn't available to extensions so when we include nsIAttribute.h we no longer build.  So I'd like to hide the constructor for nsIAttribute inside a #ifdef MOZILLA_INTERNAL_API
Attachment #274800 - Flags: review?(bzbarsky)
Blocks: 348391
Comment on attachment 274800 [details] [diff] [review]
patch

Sure.
Attachment #274800 - Flags: superreview+
Attachment #274800 - Flags: review?(bzbarsky)
Attachment #274800 - Flags: review+
Assignee: nobody → aaronr
Comment on attachment 274800 [details] [diff] [review]
patch

we need this in 1.9 to allow c++ extensions to work with libxul
Attachment #274800 - Flags: approval1.9?
Attachment #274800 - Flags: approval1.9? → approval1.9+
checked into trunk
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: