consider starting ssh-agent automatically in MozillaBuild

RESOLVED FIXED

Status

--
minor
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: myk, Assigned: myk)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 274811 [details] [diff] [review]
add ssh-agent to start-msvc*.bat files

CVS interactions in MozillaBuild are easier if you run ssh-agent and then ssh-add your key to it, but it would be even easier if ssh-agent was already running and you only had to run ssh-add.  One way to do this is to start ssh-agent before rxvt and then start rxvt as a client of ssh-agent.

I've been running MozillaBuild like this for a while now, and I can't detect any issues with it.  Here's a patch to the start-msvc*.bat files that implements it.
Attachment #274811 - Flags: review?(benjamin)
The ssh-agent process terminates when you close the rxvt, right?
(Assignee)

Comment 2

11 years ago
(In reply to comment #1)
> The ssh-agent process terminates when you close the rxvt, right?

Right.

Updated

11 years ago
Attachment #274811 - Flags: review?(benjamin) → review+
(Assignee)

Updated

11 years ago
Assignee: nobody → myk
(Assignee)

Comment 3

11 years ago
Checking in tools/build-environment/win32/start-msvc6.bat;
/cvsroot/mozilla/tools/build-environment/win32/start-msvc6.bat,v  <--  start-msvc6.bat
new revision: 1.5; previous revision: 1.4
done
Checking in tools/build-environment/win32/start-msvc71.bat;
/cvsroot/mozilla/tools/build-environment/win32/start-msvc71.bat,v  <--  start-msvc71.bat
new revision: 1.6; previous revision: 1.5
done
Checking in tools/build-environment/win32/start-msvc8.bat;
/cvsroot/mozilla/tools/build-environment/win32/start-msvc8.bat,v  <--  start-msvc8.bat
new revision: 1.7; previous revision: 1.6
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
There seems to be some invalid char (at least on my mac) after

-backspacekey

Anyone else see that?

Comment 5

11 years ago
Depends on what "invalid char" means... it's a backspace character, which is nonprintable but important for a functional shell.
That would explain it.
Mass re-assign of MozillaBuild bugs into mozilla.org:MozillaBuild
Component: Build Config → MozillaBuild
Product: Core → mozilla.org
Version: Trunk → other
QA Contact: build-config → mozillabuild
You need to log in before you can comment on or make changes to this bug.