Potential deadlock between XPCJSRuntime::mMapLockMonitor and nsComponentManagerImplMonitor

RESOLVED FIXED in mozilla1.9alpha8

Status

()

P2
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: sayrer, Assigned: brendan)

Tracking

unspecified
mozilla1.9alpha8
x86
Linux
Points:
---
Bug Flags:
blocking1.9 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

11 years ago
Created attachment 274846 [details]
stack of deadlock warning

The attached stack occurs reliably while running mochitest in debug mode.
(Assignee)

Comment 1

11 years ago
Created attachment 274856 [details] [diff] [review]
fix co-authored with mrbkap over the shoulder

diff -w coming up next.

/be
Assignee: nobody → brendan
Status: NEW → ASSIGNED
Attachment #274856 - Flags: superreview?(jst)
Attachment #274856 - Flags: review?(jst)
(Assignee)

Comment 2

11 years ago
Created attachment 274857 [details] [diff] [review]
diff -w version of last attachment

This was mrbkap's code. It seems we either care about thread safety only enough to take an atomic sample of wrappers to move, or we need to worry about races among threads reparenting. But only the DOM reparents, and DOM is main thread only, so there is no need to over-engineer here.

/be

Updated

11 years ago
Attachment #274856 - Flags: superreview?(jst)
Attachment #274856 - Flags: superreview+
Attachment #274856 - Flags: review?(jst)
Attachment #274856 - Flags: review+
(Assignee)

Comment 3

11 years ago
Would like to get this patched. Not sure about blocking-1.9+, but I don't see a wanted-1.9 flag. What to do?

/be
Flags: blocking1.9?
Priority: -- → P2
Target Milestone: --- → mozilla1.9 M8

Updated

11 years ago
Flags: blocking1.9? → blocking1.9+
(Assignee)

Comment 4

11 years ago
Fixed:

js/src/xpconnect/src/nsXPConnect.cpp 1.124

/be
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.