390554 - all PKIX_NULLCHECK_ errors are reported as "PKIX ALLOC ERROR"

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[Alexei Volkov]

Many pkix function have input arguments check. The check is done by PKIX_NULLCHECK_{ONE,TWO,THREE,FOUR} macros. If NULL check fails, then
libpkix misleadingly reports such error as "PKIX ALLOC ERROR".

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

I think this is P2, if not P1.  This will cause us no end of headache.
People will get these errors and report that NSS is leaking memory, etc.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

The PKIX_NULLCHECK_{ONE,TWO,THREE,FOUR} macros all set the error code
PKIX_NULLARGUMENT, for which the error string is "Null argument".

include/pkix_errorstrings.h:693:PKIX_ERRORENTRY(NULLARGUMENT,Null argument),
The "PKIX ALLOC ERROR" string is for PKIX_ALLOC_ERROR.  See
http://lxr.mozilla.org/security/source/security/nss/lib/libpkix/pkix_pl_nss/system/pkix_pl_lifecycle.c#52

So, where/how does PKIX_NULLARGUMENT get turned into PKIX_ALLOC_ERROR ??

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Steve, DO you know how PKIX_NULLARGUMENT gets turned into PKIX_ALLOC_ERROR ?

Comment 4

[Steve Parkinson]

I'm afraid I don't.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

If someone can give me a reproducible test case for this (may need a test 
program) I am willing to dig into it.

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

In a patch for another bug, Alexei included a one line patch for THIS bug.
It was:

Index: lib/libpkix/pkix/util/pkix_tools.h
 
 #define PKIX_ERROR_FATAL(descNum) \
     { \
 	pkixErrorReceived = PKIX_TRUE; \
 	pkixErrorMsg = PKIX_ErrorText[descNum]; \
+	pkixErrorCode = descNum; \
 	_PKIX_LOG_ERROR(pkixErrorMsg, PKIX_LOGGER_LEVEL_FATALERROR); \
 	PKIX_RETURN(FATAL); \
     }

I give r+ to the above tiny patch here.  That patch should be checked in 
by itself, separately from the patch for that other bug, with a comment 
pointing out that it is the fix for this bug.

Comment 7

[Alexei Volkov]

Fixed by patch to bug 391457