390678 - Long add-on description causes "Recommended by:" line to be displayed between two blocks

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Facebook Application, defect)

Description

[Reed Loden [:reed]]

Attachment: screenshot

As I was going through the list of add-ons looking for ones I might want to favorite, I noticed that one of the add-ons had the "Recommended by:" line wrapped between two add-ons blocks. See the screenshot to see exactly what I mean.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Happens on Mac and Windows, too.  Sorry I didn't catch this.  OS/Plat->All.

Comment 2

[Justin Scott [:fligtar]]

Attachment: patch

Fixes this and bug 390713 by trimming summary lengths.

Comment 3

[Alex Buchanan [:abuchanan]]

Comment on attachment 275493 [details] [diff] [review]
patch

fligtar++

Comment 4

[Justin Scott [:fligtar]]

Checked in; will be pushed with 0.3.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Production with Firefox 2.0.0.6 on Vista - has a description field

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Staging with Firefox 2.0.0.0.6 - no description field text at all...

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

So...I can't really read PHP (assertions to fligtar tonight on the contrary about reading diffs aside), but I'm pretty sure we wanted to truncate, rather than void, the description field if it were over some predefined length, right?

Comparing the screenshots, in staging (to which this fix is pushed), we don't display any text in the description field, but we do in production.

Justin, can you comment on the expected behavior?

Comment 8

[Justin Scott [:fligtar]]

stumbleupon is a bad example; the author actually cleared the summary in production and the dump that staging is reading from is outdated. A good add-on to test for this fix is iMacros

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #8)
> stumbleupon is a bad example; the author actually cleared the summary in
> production and the dump that staging is reading from is outdated. A good add-on
> to test for this fix is iMacros

Indeed.  I verified that, and also that iMacros is truncating fine with an ellipsis.
 
Verified FIXED using http://apps.facebook.com/add-ons-staging/browse/type:none?fb_sig_time=1186464336.949&fb_sig_user=197402349&fb_sig_profile_update_time=1186133239&fb_sig_session_key=c08fcbee436a32eed66d7f83-197402349&fb_sig_expires=0&fb_sig_api_key=7d05e667dde5b7a58d86d7e1f1da115e&fb_sig_added=1&fb_sig=af870c7738a7ada74e960824cbe06401&sort=popular&cat=72 with Firefox 2.0.0.6 (Mac OS X 10.4, Linux (Fedora), and Windows Vista).