390695 - Front page install links show incomplete versions

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Michael Morgan [:morgamic]]

I was recently talking to Tony (tchung) about a bug he found with Firebug's feature on the front page.  I found that firebug had an incomplete version (no files) that had a blank hash yet it was being linked to in the front page install link.  This was producing a hash error as you could imagine.

However, the add-ons detail page had the correct install link as well as the recommended page.  We need to figure out the difference between details page install boxes and feature install boxes -- in particular the query that gets us the file id used in the download controller URL.  They should not be different.

Comment 1

[Justin Scott [:fligtar]]

I ran into the exact same thing with the Facebook App that Stephen caught - have to use Version->getVersionByAddonId().

Comment 2

[Tony Chung [:tchung]]

Attachment: screenshot of home page addon

Comment 3

[Fred Wenzel [:wenzel]]

Attachment: patch using getVersionByAddonId

This patch should fix it: As fligtar suggested, we have a function to find the latest (valid) version, so I am using it.

Comment 4

[Michael Morgan [:morgamic]]

Comment on attachment 275228 [details] [diff] [review]
patch using getVersionByAddonId

Looks good.

Comment 5

[Fred Wenzel [:wenzel]]

I committed this to SVN r5657. Happy happy, joy joy.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; haven't run into this problem in my >=3.2 testing.