Closed Bug 390699 Opened 16 years ago Closed 16 years ago

Let DUMP_SYMS_BIN be set from environment

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

Attachments

(1 file)

Patch
1.44 KB, patch
ted
: review+
bzbarsky
: approval1.9+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
We use vc71 so we need our own binary on windows.
Attachment #274998 - Flags: review?(benjamin)
Comment on attachment 274998 [details] [diff] [review]
Patch

That's fine, but I'm still waiting on your patch to optionally build dump_syms on Win32.  ;-)
Attachment #274998 - Flags: review?(benjamin) → review+
Comment on attachment 274998 [details] [diff] [review]
Patch

a=bzbarsky
Attachment #274998 - Flags: approval1.9? → approval1.9+
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee: nobody → bent.mozilla
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.