Open links in Litmus testcases in a new window.

VERIFIED FIXED

Status

Webtools Graveyard
Litmus
VERIFIED FIXED
10 years ago
a year ago

People

(Reporter: stephend, Assigned: zach)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Summary: Open links in Litmus testcases in a new window.

Steps to Reproduce:

1. Load a litmus testcase that instructs you to click on a link.
2. Click on said link.

Expected Results:

Link opens in a new window.

Actual Results:

Link opens in the currently viewed Litmus testcase window.

I'm still trying to figure out what I can bribe Zach with.  (Cheap) suggestions welcome!
(Assignee)

Updated

10 years ago
Assignee: ccooper → zach
(Assignee)

Comment 1

10 years ago
Created attachment 276689 [details] [diff] [review]
Add target="blank" to testdata links

So this is a patch that sneaks target="blank" into links in testdata fields (steps to reproduce and expected results). It's somewhat ugly (it's literally just a regexp replace on "<a"), so I'm not entirely sure that this is what we want to be doing here, but short of an html parser, it's a working solution. Coop: are you ok with this?

stephend: I'm going out on a limb here and working on this without a firm idea of what my bribe will be. Don't let me down here...
Attachment #276689 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #276689 - Flags: review? → review?(ccooper)

Comment 2

10 years ago
Comment on attachment 276689 [details] [diff] [review]
Add target="blank" to testdata links

I might select a different name for the window ("externallink" ?), but otherwise it looks good.
Attachment #276689 - Flags: review?(ccooper) → review+
(Assignee)

Comment 3

10 years ago
fix checked in
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Reporter)

Comment 4

10 years ago
Verified FIXED--I just checked this on Firefox 2.0.0.6 on Mac OS X 10.4 and it worked.

Thanks for fixing this; bribe-planning is underway...
Status: RESOLVED → VERIFIED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.