Closed Bug 390849 Opened 13 years ago Closed 13 years ago

make nsStringContainer_base smaller

Categories

(Core :: XPCOM, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: aaronr, Assigned: aaronr)

References

Details

Attachments

(1 file)

663 bytes, patch
benjamin
: review+
benjamin
: approval1.9+
Details | Diff | Splinter Review
Attached patch patchSplinter Review
There is a problem where a nsString in the core is smaller than the nsString we get from nsStringAPI.h by 4 bytes.  You can see this by comparing nsTSubstring_CharT with nsStringContainer_base.  This is causing a problem for c++ extensions trying to work with libxul (in my case, xforms).  They need to be the same size.  bsmedberg said that we should be able to remove one of the void*'s from the front of nsStringContainer_base.  That is what this patch will do.

I tested the patch and it fixes my XForms crash.
Attachment #275160 - Flags: review?(benjamin)
Assignee: nobody → aaronr
Blocks: 348391
Attachment #275160 - Flags: review?(benjamin)
Attachment #275160 - Flags: review+
Attachment #275160 - Flags: approval1.9+
checked into trunk
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.