make nsStringContainer_base smaller

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: aaronr, Assigned: aaronr)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

663 bytes, patch
Benjamin Smedberg
: review+
Benjamin Smedberg
: approval1.9+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
Created attachment 275160 [details] [diff] [review]
patch

There is a problem where a nsString in the core is smaller than the nsString we get from nsStringAPI.h by 4 bytes.  You can see this by comparing nsTSubstring_CharT with nsStringContainer_base.  This is causing a problem for c++ extensions trying to work with libxul (in my case, xforms).  They need to be the same size.  bsmedberg said that we should be able to remove one of the void*'s from the front of nsStringContainer_base.  That is what this patch will do.

I tested the patch and it fixes my XForms crash.
Attachment #275160 - Flags: review?(benjamin)
(Assignee)

Updated

10 years ago
Assignee: nobody → aaronr
(Assignee)

Updated

10 years ago
Blocks: 348391

Updated

10 years ago
Attachment #275160 - Flags: review?(benjamin)
Attachment #275160 - Flags: review+
Attachment #275160 - Flags: approval1.9+
(Assignee)

Comment 1

10 years ago
checked into trunk
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.