Fix tab spacing in toolbar on windows

RESOLVED FIXED

Status

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: zach, Assigned: bhsieh)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
We need to make the gap between chat and settings be the right width on windows.
(Assignee)

Comment 1

11 years ago
Created attachment 275450 [details] [diff] [review]
fixes spacing, sets windows spacing to default, mac to override.

specified windows-appropriate spacing in default file. mac's platform.css should override (need a confirmation on this, but no reason it wouldn't).

I'm still unhappy with the fixed-width spacing resolution to this problem, but the xul model doesn't allow any obvious way of allowing an element's children to have more than one alignment/packing.
Attachment #275450 - Flags: review?(zach)
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 2

11 years ago
Comment on attachment 275450 [details] [diff] [review]
fixes spacing, sets windows spacing to default, mac to override.

Cool. I'll check this in tomorrow afternoon when I get back in town. After I unbreak my css weirdness with browserOverlays.xul tomorrow, how would you feel about doing a release and getting this fix out to people?
(Reporter)

Updated

11 years ago
Attachment #275450 - Flags: review?(zach) → review+
(Assignee)

Comment 3

11 years ago
I'd like to get the open-window patch in there too. Does the extension automatically update, or do we need to send out another email pointing people to the site?
(Reporter)

Comment 4

11 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Component: QA Community Extension → QA Community Extension
Product: Webtools → Other Applications
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.