Closed Bug 390907 Opened 14 years ago Closed 14 years ago

add ability for pageloader to perform self-timed tests

Categories

(Core :: General, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: vlad, Assigned: vlad)

Details

Attachments

(2 files, 1 obsolete file)

There are a large amount of tests that want to time something themselves, e.g. scrolling, dom manipulation, etc.  We need that ability in the pageloader.

This patch adds the ability to identify tests with a flag at the start of the URL in the manifest; if that flag is present, then it adds a tpRecordTime() function to the test's global object that takes a single argument -- the time that the test should report.

This patch also makes the manifest parsing more robust, and adds the ability to use "include" for sub-manifests, much like the reftest manifest loader does.  It also removes the -tpprefix command line option; tests are now manifest-relative, so there is no real need for it.
An initial pageset is available at http://vlad.off.net/hg/pageset/ -- this includes the synthetic Tr tests (which don't take advantage of this feature), as well as the classic DHTML benchamrks (which do).
Attached patch updated patchSplinter Review
Updated with shaver's irc comments.
Assignee: nobody → vladimir
Attachment #275227 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Attached patch stupid followupSplinter Review
Typo in strPadFixed -- didn't catch this because I didn't test the text report format.  Also, we have to do 250ms timeouts, because 0 doesn't work for some reason; invalidations are lost.
Attachment #276160 - Flags: review+
You need to log in before you can comment on or make changes to this bug.