390907 - add ability for pageloader to perform self-timed tests

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: add self-timed tests to pageloader

There are a large amount of tests that want to time something themselves, e.g. scrolling, dom manipulation, etc.  We need that ability in the pageloader.

This patch adds the ability to identify tests with a flag at the start of the URL in the manifest; if that flag is present, then it adds a tpRecordTime() function to the test's global object that takes a single argument -- the time that the test should report.

This patch also makes the manifest parsing more robust, and adds the ability to use "include" for sub-manifests, much like the reftest manifest loader does.  It also removes the -tpprefix command line option; tests are now manifest-relative, so there is no real need for it.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

An initial pageset is available at http://vlad.off.net/hg/pageset/ -- this includes the synthetic Tr tests (which don't take advantage of this feature), as well as the classic DHTML benchamrks (which do).

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: updated patch

Updated with shaver's irc comments.

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 275463 [details] [diff] [review]
updated patch

r=shaver, fwiw.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: stupid followup

Typo in strPadFixed -- didn't catch this because I didn't test the text report format.  Also, we have to do 250ms timeouts, because 0 doesn't work for some reason; invalidations are lost.