390934 - When document contains contenteditable element, drag-dropping seems possible anywhere in the document

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Martijn Wargers (dead)]

See testcase, which comes from bug 389372.

Drag some text from outside the contenteditable element and move it around in the document.
You never get the 'not-allowed' mouse cursor anymore, even when you drag over stuff where you can't drop it on.

Comment 1

[Albert Brand]

And with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007111312 Minefield/3.0b2pre ID:2007111312, I get a consistent crash when drag-dropping a text this way.

Comment 2

[Martijn Wargers (dead)]

That's bug 403664 (should be fixed in today's build).

Comment 3

[spam]

Some additional information on this bug. It seems to insert a BR element each time you drop contents. I've made another test case page for this behavior.

http://tinymce.moxiecode.com/gecko/contenteditable_dragdrop.htm

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: v1 (diff -w)

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 316040 [details] [diff] [review]
v1 (diff -w)

The editor's drag listener should bail out if the drag is over non-editable content and let the other handlers deal with it. Still working on an automated testcase.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 316040 [details] [diff] [review]
v1 (diff -w)

Looks good, r+sr=jst

Comment 7

[Peter Van der Beken [:peterv]]

Comment on attachment 316040 [details] [diff] [review]
v1 (diff -w)

Simple fix, low risk. Haven't found a way yet to write an automated test for this.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 316040 [details] [diff] [review]
v1 (diff -w)

a1.9=beltzner