390949 - ecma/String/15.5.4.6-2.js FAIL browser - NS_ERROR_UNEXPECTED

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Bob Clary [:bc] (inactive)]

the following tests regressed in the browser between 8/2 - 8/3

ecma/String/15.5.4.6-2.js
ecma/ObjectObjects/15.2.4.2.js
js1_6/Regress/regress-353078.js
ecma/ObjectObjects/15.2.2.1.js

Comment 1

[Brian Crowder]

bc:  Are these tests still failing?  If so, is there any way you can narrow down the time-range?  This seems to have been a particularly busy check-in period.

Comment 2

[Bob Clary [:bc] (inactive)]

yes, they are still failing. I'll try to get a better range today depending on how hughesnet treats me.

Comment 3

[Damon Sicore (:damons)]

Blocking and P4.  Let's get more details here.

Comment 4

[Bob Clary [:bc] (inactive)]

bonsai 2007-08-02 15:00 and 2007-08-02 16:40 says bug 390626

Comment 5

[Brian Crowder]

That means you, mrbkap.  Any thoughts?

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

The problem is that we're not setting the 'resolving' flag, so when we get the AddProperty notification when we're defining toString, we pass it along to our wrapped object. The fix is to toggle the flag around the JS_DefineFunction call.

Note that, even with this patch, we fail one of the tests. I blame bug 394012 for the failure.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 8

[Bob Clary [:bc] (inactive)]

(In reply to comment #6)

> Note that, even with this patch, we fail one of the tests. I blame bug 394012
> for the failure.


mrbkap, 

ecma/ObjectObjects/15.2.4.2.js does still fail with 
myvar = this;  myvar.toString = Object.prototype.toString; myvar.toString()  expected: [object Window] actual: [object XPCCrossOriginWrapper]  which I think you are referring, but there is a new failure in debug minefield builds with the test for 
var MYVAR = new Object( this ); MYVAR.toString() and expected: [object Window] actual: [object Window @ 0xb4996f18 (native @ 0xb49961c4)]

I'm not actually clear that this is a bug, but it is a change from 1.8.1 and from before the patch. It may mean something or not. I'll let you make the call. Otherwise it looks pretty good. Thanks!

Checking in public-failures.txt;
/cvsroot/mozilla/js/tests/public-failures.txt,v  <--  public-failures.txt
new revision: 1.14; previous revision: 1.13

Comment 9

[Bob Clary [:bc] (inactive)]

I missed a couple of additional tests fixed by this patch.

/cvsroot/mozilla/js/tests/public-failures.txt,v  <--  public-failures.txt
new revision: 1.15; previous revision: 1.14

Comment 10

[Bob Clary [:bc] (inactive)]

NS_ERROR_UNEXPECTED verified fixed 1.9.0.

mrbkap, what do you think about the remaining failure I mentioned in comment 8?