Closed Bug 391039 Opened 18 years ago Closed 18 years ago

Change the contract id used by the spell checker engine

Categories

(Core :: Spelling checker, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta2

People

(Reporter: mscott, Assigned: RyanVM)

Details

Attachments

(1 file)

Spun off from Bug 319778. Currently the contract ID used to create an instance of the spell check engine is engine specific. i.e. "@mozilla.org/spellchecker/hunspell;1" the contract ID itself should be engine neutral like: "@mozilla.org/spellchecker/engine;1"
I'll take this.
Status: NEW → ASSIGNED
OS: Windows Vista → All
Hardware: PC → All
Assignee: mscott → ryanvm
Status: ASSIGNED → NEW
Tested OK with Fx, Tb, and SM
Attachment #288198 - Flags: superreview?(mscott)
Attachment #288198 - Flags: review?(mscott)
Comment on attachment 288198 [details] [diff] [review] Rename Contract ID from hunspell to engine thanks Ryan!
Attachment #288198 - Flags: superreview?(mscott)
Attachment #288198 - Flags: superreview+
Attachment #288198 - Flags: review?(mscott)
Attachment #288198 - Flags: review+
Attachment #288198 - Flags: approval1.9?
Attachment #288198 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Attachment #288198 - Attachment description: Rename CID from hunspell to engine → Rename Contract ID from hunspell to engine
Checking in mail/components/compose/content/MsgComposeCommands.js; /cvsroot/mozilla/mail/components/compose/content/MsgComposeCommands.js,v <-- MsgComposeCommands.js new revision: 1.121; previous revision: 1.120 done Checking in mail/components/preferences/compose.js; /cvsroot/mozilla/mail/components/preferences/compose.js,v <-- compose.js new revision: 1.20; previous revision: 1.19 done Checking in extensions/spellcheck/hunspell/src/mozHunspell.h; /cvsroot/mozilla/extensions/spellcheck/hunspell/src/mozHunspell.h,v <-- mozHunspell.h new revision: 1.3; previous revision: 1.2 done Checking in extensions/spellcheck/osxspell/src/mozOSXSpell.h; /cvsroot/mozilla/extensions/spellcheck/osxspell/src/mozOSXSpell.h,v <-- mozOSXSpell.h new revision: 1.3; previous revision: 1.2 done Checking in extensions/spellcheck/src/mozSpellChecker.cpp; /cvsroot/mozilla/extensions/spellcheck/src/mozSpellChecker.cpp,v <-- mozSpellChecker.cpp new revision: 1.15; previous revision: 1.14 done Checking in editor/ui/dialogs/content/EdSpellCheck.js; /cvsroot/mozilla/editor/ui/dialogs/content/EdSpellCheck.js,v <-- EdSpellCheck.js new revision: 1.65; previous revision: 1.64 done Checking in mailnews/compose/prefs/resources/content/pref-composing_messages.js; /cvsroot/mozilla/mailnews/compose/prefs/resources/content/pref-composing_messages.js,v <-- pref-composing_messages.js new revision: 1.6; previous revision: 1.5 done Checking in mailnews/compose/resources/content/MsgComposeCommands.js; /cvsroot/mozilla/mailnews/compose/resources/content/MsgComposeCommands.js,v <-- MsgComposeCommands.js new revision: 1.407; previous revision: 1.406 done
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: