391047 - thunderbird failed to build on OpenSolaris

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Ginn Chen]

Undefined			first referenced
 symbol  			    in file
unsigned nsAbDirProperty::CreateNewDirectory(const nsAString_internal&,const nsACString_internal&,unsigned,nsACString_internal&) ../../staticlib/components/libmail.a(nsAbMDBDirectory.o)

bustage of Bug 331557
nsAbDirProperty::CreateNewDirectory(const nsAString &aDirName,      
                                    const nsACString &aURI,
                                    const PRUint32 aType, nsACString &aResult)
NS_IMETHODIMP nsAbBSDirectory::CreateNewDirectory(const nsAString &aDirName,                               
                                                  const nsACString &aURI,       
                                                  const PRUint32 aType,         
                                                  nsACString &aResult) 
doesn't perfect match the function declared in the idl file.

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[[e-mail]]

Shouldn't you have changed the headers too?

Comment 3

[Ginn Chen]

Attachment: patch for header

I didn't notice there's a header for this function.
I thought they're both using header from idl.

Comment 4

[David :Bienvenu]

I coded the second patch myself before I knew about this patch - it's checked in now, in bug 391746

Comment 5

[Scott MacGregor]

Comment on attachment 275763 [details] [diff] [review]
patch for header

clearing review request since David fixed this already.