Closed Bug 391066 Opened 17 years ago Closed 17 years ago

Importing Eudora Address books will crash on Windows at [@nsEudoraWin32::FindAddressBooks]

Categories

(MailNews Core :: Import, defect)

Product:
MailNews Core
Component:
Import
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: standard8, Assigned: Bienvenu)

References

(
URL
)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

proposed fix
1.23 KB, patch
mscott
: superreview+
Details | Diff | Splinter Review 
When you look at it the problem is fairly obvious, we're creating a pointer to a nsILocalFile and then not initialising it before using it :-(

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/import/eudora/src/nsEudoraWin32.cpp&rev=1.55&mark=1186-1188#1183

Looks like a regression from the nsFileSpec -> nsIFile change over.
Summary: Trunk builds crashing at [@nsEudoraWin32::FindAddressBooks] → Importing Eudora Address books will crash on Windows at [@nsEudoraWin32::FindAddressBooks]
Attached patch proposed fix — — Splinter Review 
Assignee: nobody → bienvenu
Status: NEW → ASSIGNED

        Attachment #275459 -
        Flags: superreview?(mscott)

    
  

        Attachment #275459 -
        Flags: superreview?(mscott) → superreview+

    
    

    
  
fixed, thx for pointing this out, Mark.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
Crash Signature: [@nsEudoraWin32::FindAddressBooks]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: