391121 - Search resizer can squish / squash navigation buttons

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P4)

Description

[u88484]

Attachment: Screenshot

After landing of bug 267831 to add a resizer for resizing the search bar, if you move the resize to the left to compress the address bar, eventually the navigation buttons squish.  They don't return to normal size after moving the resizer to the opposite direction.

Comment 1

[Neil Deakin]

Attachment: only resize flexible items

This fixes the bug by making splitters skip non-flexible elements when resizing. However I'm quite concerned that this will cause some regressions elsewhere.

Comment 3

[u88484]

Comment on attachment 276021 [details] [diff] [review]
only resize flexible items

I assume this meant to have a review request?

Comment 4

[Steffen Wilberg]

Comment on attachment 276021 [details] [diff] [review]
only resize flexible items

Mano is not a reviewer for layout/xul, see http://www.mozilla.org/owners.html#xptoolkit. And Neil will request review himself once he is ready to do so.

Comment 5

[u88484]

Sorry, seen he reviewed the code that added the resizer so figured he could review this also. Plus I thought after 13 days he would have requested review for a three line change if he remembered or meant to but didn't.  Sorry again.

Comment 6

[Neil Deakin]

No, this isn't the patch I want to use, as it will cause the behaviour of splitters to change in some cases (horizontal scrolling trees for example).

Instead, I'll probably need to add a different attribute or value to control this.
  

Comment 8

[u88484]

Attachment: Screenshot 2

Related? I removed the location bar by accident while trying to remove the resizer. My toolbar was setup like this |home|locationbar|resizer|search bar|
The resizer ended up next to the home button and then became "attached to the home button, which allowed for me to resize the home button.

Comment 9

[u88484]

Attachment: screenshot 3

This is after performing steps from last comment.  I added the location back but this time on the left side of the home button  and due to it being so large, pushed the search bar off screen and its inacessible.  Should be able to push things of screen.

Comment 11

[Neil Deakin]

This was fixed by bug 400327.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007111604 Minefield/3.0b2pre.

The resizer is only visible if the location and search bar are positioned side by side. So navigation buttons cannot be squished. 

Comment 13

[Neil Deakin]

> The resizer is only visible if the location and search bar are positioned side
> by side. So navigation buttons cannot be squished. 

It's true that the buttons cannot be squished, but having both fields next to each other isn't the reason. A change was made so that spliiters have the option of only resizing flexible items. 

Comment 16

[Marcia Knous [:marcia]]

Litmus triage team: tomcat will handle testcase.

Comment 17

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=5083 has been added in Litmus.