391137 - MochiTest's runtests.pl omits separator between $bestmatch and appended dirs

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: make sure $bestmatch ends in a backslash

MochiTest's runtests.pl omits the directory separator between the $bestmatch path and the directories it appends to that path in winPathFromDir, resulting in incorrect paths that run two directories together, preventing MochiTest from working.

For example, on my system, mount returns the following output:

C:\DOCUME~1\myk\LOCALS~1\Temp on /tmp type user (binmode,noumount)
C:\mozilla-build\msys on / type user (binmode,noumount)
C:\mozilla-build\msys on /usr type user (binmode,noumount)
a: on /a type user (binmode,noumount)
c: on /c type user (binmode,noumount)
d: on /d type user (binmode,noumount)
z: on /z type user (binmode,noumount)

And "perl runtests.pl" returns the following output (and then hangs and eventually times out waiting for xpcshell (which has quit in the meantime because it was passed bad paths):

/home/myk/Mozilla/builds/minefield-debug/_tests/testing/mochitest/../../../dist/bin/xpcshell -v 170  -f "C:\mozilla-build\msyshome\myk\Mozilla\builds\minefield-debug\_tests\testing\mochitest\httpd.js" -f "C:\mozilla-build\msyshome\myk\Mozilla\builds\minefield-debug\_tests\testing\mochitest\server.js"
No error message available for error number 1
No error message available for error number 1
nsStringStats
 => mAllocCount:           2455
 => mReallocCount:            1
 => mFreeCount:            2455
 => mShareCount:           2350
 => mAdoptCount:            158
 => mAdoptFreeCount:        158

In my case, $bestmatch is C:\mozilla-build\msys and the first dir to get appended to it is "home", which results in a path starting:

C:\mozilla-build\msyshome

Here's a patch that makes sure $bestmatch ends with a backslash to prevent the problem from occurring.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: simpler solution

Hmm, since Windows does the right think with duplicate backslashes, we can just inpend one between $bestmatch and the first appended directory.  We don't have to actually test for the trailing backslash on $bestmatch first.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 275486 [details] [diff] [review]
patch v2: simpler solution

Tested this with MSYS, works fine.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 275486 [details] [diff] [review]
patch v2: simpler solution

Requesting an additional review from sayrer, since it's unclear why this works on other systems and not on mine.

Comment 4

[Robert Sayre]

Comment on attachment 275486 [details] [diff] [review]
patch v2: simpler solution

if extra slashes don't cause problems, this is fine with me.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Checking in testing/mochitest/runtests.pl.in;
/cvsroot/mozilla/testing/mochitest/runtests.pl.in,v  <--  runtests.pl.in
new revision: 1.30; previous revision: 1.29
done

Comment 6

[(not currently active) Ted Mielczarek]

MochitestMassMove -- plz ignore.