391172 - People without labels are sometimes shown as recommending an add-on

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Facebook Application, defect)

Description

[Justin Scott [:fligtar]]

Attachment: screenshot

It's very easy to find empty recommendations for an add-on with lots of recommenders.

Initial thoughts have to do with Facebook permissions that those users might have set.

Comment 1

[Justin Scott [:fligtar]]

Yeah, it was a permissions problem. If the logged in user can't view a user's name (this is now possible for users to set in privacy settings) the problem happens.

I can't detect this server-side without making lots of calls to the Facebook API, so I'm using some FBML to display "Anonymous" instead of no name under the picture if the user can't see it.

This is checked in and will be pushed with 0.3, if not sooner.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of staging; looks good.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with Firefox 2.0.0.6 on Mac OS X 10.4, Linux (Fedora Core), and Windows Vista with staging: http://apps.facebook.com/add-ons-staging/favorites/addon/1865

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

http://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=4535

in-litmus+