391194 - %20, %23, and presumably all escape-character sequences are causing RYF's search to spew

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Facebook Application, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: %20, %23, and presumably all escape-character sequences are causing RYF's search to spew

Steps to Reproduce:

1. Enter %20 or another escape-character sequence into the Search Add-ons: or Searching for textfields.  Click Search or press Enter.


Expected Results:

Should either be silently escaped, or--if feasible--we could throw up an alert (through JS), or print out a message bemoaning the user's invalid input :-)

Actual Results:

"1/ # apps.facebook.com/add-ons/search/type:none/page:3/?q=>3
# /apps.facebook.com/add-ons/search/type:none/page:5/?q=>5
# Next"

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of said weirdness

Comment 2

[Justin Scott [:fligtar]]

This is fixed in trunk. (same fix as bug 391192)

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using %20, %23, and a few other escape-character sequences; we no longer garble the page-number navigation view, with Mac OS X 10.4, Linux (Fedora Core), and Windows XP SP2 trunk 2.0.0.6 versions of Firefox (and GranParadiso alpha/M7 builds).

This was tested on staging: http://apps.facebook.com/add-ons-staging/

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

http://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=4534

in-litmus+