Add "report using breakpad" to the assertion-failure dialog

RESOLVED INVALID

Status

()

Toolkit
Crash Reporting
--
enhancement
RESOLVED INVALID
11 years ago
9 years ago

People

(Reporter: Ed Avis, Unassigned)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071605 Minefield/3.0a7pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071605 Minefield/3.0a7pre

The crash reporter included with Firefox builds is really useful.  At least for me, Firefox crashes a lot and it saves time not to have to file a bug each time ;-).  Could you do the same for assertion failures - have them be reported automatically?

Failing that at least make the assertion failure dialogue box have a 'copy to clipboard' button.

Reproducible: Always

Steps to Reproduce:
1. Trigger an assertion failure (somehow...)
Actual Results:  
Dialogue box pops up.  All you can do is press OK.

Expected Results:  
Should prompt 'do you wish to send a crash report back to Mozilla?'

Comment 1

11 years ago
an assertion already contains some useful information and a bug report on bugzilla is always needed to put infos for fix the problem... While with an assert you have only to copy paste the assert in bugzilla, with a crash you don't have useful informations, other than the crash reporter dump, so i think that there is not a big deal in having assertion reported automatically as crashes. 

Updated

11 years ago
Component: General → Breakpad Integration
Product: Firefox → Toolkit
QA Contact: general → breakpad.integration
Summary: Feature: assertion failures reported with talkback thingy → Add "report using breakpad" to the assertion-failure dialog
Version: unspecified → Trunk
Probably would need bug 381049 fixed to work.

Comment 3

11 years ago
I wouldn't bother with that -- just add |*(int*) 0 = 0;| to code that executes when an appropriate button is pressed (after the dialog is closed) and let the normal stack walking code handle the details -- you're getting line numbers and enough detail to basically determine what assert fired anyway, I'd expect.  Or am I missing something here that you'd get with a crash you can pass in?

Comment 4

11 years ago
It would be nice if you could continue browsing after reporting the assertion stack...
So, what kind of assertions are you talking about here? Debug build assertions? If so, then this doesn't make any sense, as we don't ship debug builds, and therefore submitting crash reports from something we didn't ship isn't useful.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.