Please svn up facebook.addons.mozilla.org for a few updates. Bugs fixed in this update and verified by Stephen: bug 391172 bug 391194 bug 391192 bug 390678 bug 390713 CC'ing cbeard and stephend for signoff.
Sadly, there were a few things I missed in my first round of testing that I've now flagged as needing Litmus test coverage ("in-litmus?" in each bug); I'll be writing up specific, clear testcases to ensure that such issues won't regress in the future. I still feel confident and proud of the quality of the in-production application, and I think the reviews garnered echo that. While I haven't done a full functional on all three platforms this time around, I've run that on Firefox 18.104.22.168 for Windows XP SP2, with verification of all of the above bugs also done on Mac OS X 10.4 and Fedora Core, so I feel confident that this subset hasn't regressed anything (and the fixes, as Justin says elsewhere, are important to improve not only quality but also shield from a potential XSS-injection attack). So, to be succinct rather than the above verbosity, QA has signed off.
Do I need to wait for cbeard or is stephend's sign off sufficient?
Yes, cbeard's approval is needed (per cbeard). (In reply to comment #2) > Do I need to wait for cbeard or is stephend's sign off sufficient? >
U . Fetching external item into 'site' A site/app/locale/ko/pages/submission_help.thtml U site/app/controllers/facebook_controller.php U site/app/views/helpers/facebook.php U site/app/views/facebook/view.thtml U site/app/views/facebook/faq.thtml Updated external to revision 5634. Updated to revision 5682.