Closed Bug 391271 Opened 15 years ago Closed 15 years ago

Register the GRE during XULRunner's "make install"

Categories

(Toolkit Graveyard :: XULRunner, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: benjamin, Assigned: benjamin)

Details

Attachments

(1 file)

We should register the GRE during XULRunner's "make install"
Attachment #275656 - Flags: review?(ted.mielczarek)
Comment on attachment 275656 [details] [diff] [review]
Register GRE during XR "make install", rev. 1

>Index: xulrunner/installer/Makefile.in
>+$(MOZILLA_VERSION).system.conf: $(topsrcdir)/config/milestone.txt Makefile
>+	printf "[%s]\nGRE_PATH=%s\nxulrunner=true" $(MOZILLA_VERSION) $(installdir)> $@

I guess I don't know exactly how GRE registration works, but this will give you a file like 1.9.system.conf which contains
[1.9]
GRE_PATH=/whatever

?

Why does the filename have the version in it?
Attachment #275656 - Flags: review?(ted.mielczarek) → review+
The filename has the version in it so that you can register multiple XULRunners side-by-side without them interfering with eachother:

/etc/gre.d/1.9.system.conf
/etc/gre.d/1.9.0.1.system.conf
/etc/gre.d/1.9.1.system.conf

And self-built XULRunners which are registered using --register-global will not have the .system modifier so there will be no conflicts at all.
Fixed on trunk
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
This is causing "make install" to fail here:

.../nsinstall: cannot create /etc/gre.d/1.9a8pre.system.conf: Permission denied

Why is this trying to write into the system /etc directory, instead of ${prefix}/etc ?
Because XR looks for the file in /etc, not in ${prefix}/etc
Assignee: nobody → benjamin
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.