From https://bugzilla.mozilla.org/show_bug.cgi?id=387970#0 -- Bootstrap::Step::Shell() needs to use sysvar when Config::Get()ing logDir; if you don't, various steps refuse to run on Win32, because in bootstrap.cfg, we only have one logDir specified, and on Win32, the logDir path is different, due to cygwin. I tried to fix this by adding a win32_logDir, but that doesn't work because Shell() doesn't use sysvar. The patch addresses all lookups of logDir. I'd like to get this into a _M5_1 milestone for TB220.127.116.11.
Priority: -- → P2
Summary: Using sysvar when calling Get() → Use sysvar when looking up logDir with $config->Get()
Created attachment 275730 [details] [diff] [review] Use sysvar instead of var
Attachment #275730 - Flags: review?(preed)
Comment on attachment 275730 [details] [diff] [review] Use sysvar instead of var Looks good; in thinking about it more, this technically isn't necessary. The problem is that we want the logs to go in with the release area on win32, and we *could* actually create a log dir in %CYGWINROOT%/builds/logs, but we never do that (because we want them with the release stuff, as I said ;-)... Anyway, looks good.
Attachment #275730 - Flags: review?(preed) → review+
Checking in Bootstrap/Step.pm; /cvsroot/mozilla/tools/release/Bootstrap/Step.pm,v <-- Step.pm new revision: 1.13; previous revision: 1.12 done Checking in Bootstrap/Step/Build.pm; /cvsroot/mozilla/tools/release/Bootstrap/Step/Build.pm,v <-- Build.pm new revision: 1.10; previous revision: 1.9 done Checking in Bootstrap/Step/PatcherConfig.pm; /cvsroot/mozilla/tools/release/Bootstrap/Step/PatcherConfig.pm,v <-- PatcherConfig.pm new revision: 1.2; previous revision: 1.1 done Checking in Bootstrap/Step/Repack.pm; /cvsroot/mozilla/tools/release/Bootstrap/Step/Repack.pm,v <-- Repack.pm new revision: 1.15; previous revision: 1.14 done Checking in Bootstrap/Step/Sign.pm; /cvsroot/mozilla/tools/release/Bootstrap/Step/Sign.pm,v <-- Sign.pm new revision: 1.6; previous revision: 1.5 done Checking in Bootstrap/Step/Source.pm; /cvsroot/mozilla/tools/release/Bootstrap/Step/Source.pm,v <-- Source.pm new revision: 1.7; previous revision: 1.6 done Checking in Bootstrap/Step/Stage.pm; /cvsroot/mozilla/tools/release/Bootstrap/Step/Stage.pm,v <-- Stage.pm new revision: 1.15; previous revision: 1.14 done Checking in Bootstrap/Step/Tag.pm; /cvsroot/mozilla/tools/release/Bootstrap/Step/Tag.pm,v <-- Tag.pm new revision: 1.11; previous revision: 1.10 done Checking in Bootstrap/Step/TinderConfig.pm; /cvsroot/mozilla/tools/release/Bootstrap/Step/TinderConfig.pm,v <-- TinderConfig.pm new revision: 1.3; previous revision: 1.2 done Checking in Bootstrap/Step/Updates.pm; /cvsroot/mozilla/tools/release/Bootstrap/Step/Updates.pm,v <-- Updates.pm new revision: 1.13; previous revision: 1.12 done Checking in Bootstrap/Step/Tag/Bump.pm; /cvsroot/mozilla/tools/release/Bootstrap/Step/Tag/Bump.pm,v <-- Bump.pm new revision: 1.10; previous revision: 1.9 done Checking in Bootstrap/Step/Tag/Mozilla.pm; /cvsroot/mozilla/tools/release/Bootstrap/Step/Tag/Mozilla.pm,v <-- Mozilla.pm new revision: 1.4; previous revision: 1.3 done Checking in Bootstrap/Step/Tag/Talkback.pm; /cvsroot/mozilla/tools/release/Bootstrap/Step/Tag/Talkback.pm,v <-- Talkback.pm new revision: 1.5; previous revision: 1.4 done Checking in Bootstrap/Step/Tag/l10n.pm; /cvsroot/mozilla/tools/release/Bootstrap/Step/Tag/l10n.pm,v <-- l10n.pm new revision: 1.6; previous revision: 1.5 done Checking in configs/fx-moz18-bootstrap.cfg; /cvsroot/mozilla/tools/release/configs/fx-moz18-bootstrap.cfg,v <-- fx-moz18-bootstrap.cfg new revision: 1.12; previous revision: 1.11 done Checking in configs/fx-moz180-bootstrap.cfg; /cvsroot/mozilla/tools/release/configs/fx-moz180-bootstrap.cfg,v <-- fx-moz180-bootstrap.cfg new revision: 1.4; previous revision: 1.3 done Checking in configs/tb-moz18-bootstrap.cfg; /cvsroot/mozilla/tools/release/configs/tb-moz18-bootstrap.cfg,v <-- tb-moz18-bootstrap.cfg new revision: 1.9; previous revision: 1.8 done Checking in configs/tb-moz180-bootstrap.cfg; /cvsroot/mozilla/tools/release/configs/tb-moz180-bootstrap.cfg,v <-- tb-moz180-bootstrap.cfg new revision: 1.5; previous revision: 1.4 done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.