216.62 KB, patch
|Details | Diff | Splinter Review|
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:188.8.131.52) Gecko/20070723 Iceweasel/184.108.40.206 (Debian-220.127.116.11-1) Build Identifier: 20070807 Although '--disable-strip' is passed to ./configure, all binaries in $(pkglibdir) are installed without debugging symbols. This makes debugging impossible. Reproducible: Always Steps to Reproduce: 1. ./configure ... --disable-strip ... 2. make 3. make install Actual Results: sizeof libxul.so is 15Mb Expected Results: sizeof libxul is ~140Mb Stripping seems to occur in 'stage-package' make target.
--disable-strip is the default, and it strips "immediately" as we build the objects in rules.mk We probably need a separate --disable-install-strip or something to indicate that the installed files shouldn't be stripped. As a workaround, you can set PKG_SKIP_STRIP to avoid stripping the packaged bits.
May be it makes sense to set PKG_SKIP_STRIP to (! ENABLE_STRIP) by default, and then separately configure the former with '--enable-install-strip'? I can make this kind of patch to 'configure.in'.
Given the way mozilla typically does releases, this does not make sense: We do release builds without --enable-strip: then we separate out the debug symbols for the crash-reporting application and package up the bits for release (stripping them in the process). Changing this default behavior now is not really practical. However, adding an --disable-install-strip flag is perfectly reasonable. If you can do it, I'm happy to review, or I can probably get to it at some point, maybe next week.
Created attachment 275819 [details] [diff] [review] patch adds '--enable-install-strip' ./configure option If '--disable-install-strip' option is supplied, PKG_SKIP_STRIP=1 is set.
Comment on attachment 275819 [details] [diff] [review] patch adds '--enable-install-strip' ./configure option You need an AC_SUBST(PKG_SKIP_STRIP) or the variable will never be substituted ;-)
Created attachment 275821 [details] [diff] [review] patch adds '--enable-install-strip' ./configure option v2 I have already gone home, but remembered AC_SUBST :) So I am back. Its 23:44 in Moscow.
r=me and fixed on trunk