Closed
Bug 391338
Opened 17 years ago
Closed 17 years ago
Remove popup tree hover event coordinate hacks
Categories
(Toolkit :: Autocomplete, defect)
Toolkit
Autocomplete
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
()
Details
Attachments
(1 file)
|
5.68 KB,
patch
|
enndeakin
:
review+
mscott
:
review+
|
Details | Diff | Splinter Review |
Now that bug 385536 is fixed we can just use event.clientX/Y
|
Assignee | |
Comment 1•17 years ago
|
||
I also had to add the ignorekeys="true" attribute to fix an apparent keyboard regression in the folder pickers (as used in advanced search or filter editor)
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #275748 -
Flags: review?(mscott)
Attachment #275748 -
Flags: review?(enndeakin)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 275748 [details] [diff] [review] Proposed patch Should the popups actually be panels then? Or is that what I think you asked me about several times ;) You could also remove the popupshown event handler too. The issue is that enableKeyboardNavigator is expected to be called before the popup is shown.
Attachment #275748 -
Flags: review?(enndeakin) → review+
|
||
Updated•17 years ago
|
Attachment #275748 -
Flags: review?(mscott) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Fix checked in. (In reply to comment #2) >Should the popups actually be panels then? They are children of <menulist> elements so perhaps not.
|
||
Comment 4•17 years ago
|
||
The fix is checked in, so this bug can be marked fixed?
|
|
Assignee | |
Comment 5•17 years ago
|
||
Yeah, oversight when I commented, I guess...
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/11b7efd84beb Remove popup tree hover event coordinate hacks r=Enn,mscott
You need to log in
before you can comment on or make changes to this bug.
Description
•