update to breakpad revision 198

RESOLVED FIXED

Status

()

Toolkit
Crash Reporting
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Alfred Peng, Assigned: Alfred Peng)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
Sync us up to Breakpad r198, which includes the Solaris port of breakpad client.
(Assignee)

Comment 1

11 years ago
Created attachment 275773 [details] [diff] [review]
sync to revision 198

Besides the Solaris port, also contain the following two issues:
1. Fix permissions on dump file in MinidumpFileWriter.
2. Crash when processing file names less than 4 bytes.
Attachment #275773 - Flags: review?(ted.mielczarek)
Depends on: 389548
Comment on attachment 275773 [details] [diff] [review]
sync to revision 198

Pretty harmless, except for the Solaris code, there aren't any major changes in here.  I do want to get bug 389548 landed first though, to stop using toolkit/airbag.
Attachment #275773 - Flags: review?(ted.mielczarek) → review+
Almost forgot, when we land this we don't want to add
src/client/solaris/handler/Makefile

Makefiles just get in the way of our build system, so we haven't been importing them to CVS.
(Assignee)

Comment 4

11 years ago
Created attachment 275803 [details] [diff] [review]
revised patch without "Makefile"

luser, I notice that bug 389548 has been landed. Any other approvals I need to get before checking in this patch?
No, I think you're ok, once the tree is green.  :)  Just remember you'll have to CVS add all the new files (but please leave out that Makefile).
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

11 years ago
Assignee: nobody → alfred.peng
Status: ASSIGNED → NEW
(Assignee)

Comment 6

11 years ago
Patch checked in.

=>FIXED.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.