Need to clean up URLs before adding them to a crash report

RESOLVED FIXED in Firefox 3.1a2

Status

()

Firefox
Session Restore
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: Adam Guthrie, Assigned: Adam Guthrie)

Tracking

({privacy})

Trunk
Firefox 3.1a2
privacy
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.45 KB, patch
Gavin
: review+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
If someone is viewing a URL that has a username and password in it; e.g.

https://username:password@sexytime.com/sexyfile.wmv

we need to clear out the username and password section of the URL before adding it to a crash report.
(Assignee)

Comment 1

11 years ago
Created attachment 276187 [details] [diff] [review]
patch

This works, except it isn't happy with URLs such as about:config, resulting in an error getting dumped to the console for each blank tab opened. I guess I could just wrap the call in another try/catch block... Any suggestions?
Ideally you could just use nsIURIFixup::createExposableURI, but that seems to obey a pref for whether to remove the username/password, which we don't really want. I guess just wrapping it in a try/catch is the way to go, since you don't really care about the other stuff createExposableURI does.
(Assignee)

Updated

10 years ago
Assignee: ispiked → nobody

Comment 3

9 years ago
Adam: Any progress on this issue?
Keywords: privacy
(Assignee)

Comment 4

9 years ago
Created attachment 334631 [details] [diff] [review]
patch v1.1

Updated to comments. Do I need some sort of test to go along with this nowadays?
Assignee: nobody → ispiked
Attachment #276187 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #334631 - Flags: review?(gavin.sharp)
Comment on attachment 334631 [details] [diff] [review]
patch v1.1

For the moment sessionstore is disabled during tests so you wouldn't be able to anyways.
Attachment #334631 - Flags: review?(gavin.sharp) → review+
Keywords: checkin-needed
Pushed as 17131:fc3a6529896e.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a2
You need to log in before you can comment on or make changes to this bug.