391448 - Force layout/dom/content code to use classinfo macros that don't use the service manager.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Johnny Stenback (:jst)]

Attachment: Make NS_INTERFACE_MAP_ENTRY_DOM_CLASSINFO cause a compiler error when _IMPL_NS_LAYOUT is defined.

There's a couple of users left (or new ones since the faster macros were added) that still use the slower macros in layour/dom/content code for getting the DOM classinfo stuff in their QI implementations. There's no reason for this, and I decided to make using the slower ones a compiler error while I was fixing these... Patch coming up.

Comment 1

[Johnny Stenback (:jst)]

Oh, and if someone knows of a cleaner and more informative way to trigger a compiler error in this case, please do speak up :)

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 275862 [details] [diff] [review]
Make NS_INTERFACE_MAP_ENTRY_DOM_CLASSINFO cause a compiler error when _IMPL_NS_LAYOUT is defined.

We could also, instead of failing to compile, rename NS_INTERFACE_MAP_ENTRY_DOM_CLASSINFO to NS_DOM_INTERFACE_MAP_ENTRY_CLASSINFO, convert the few remaining callers in the tree and change the implementation of the one macro (NS_DOM_INTERFACE_MAP_ENTRY_CLASSINFO) based on the value of _IMPL_NS_LAYOUT.

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: v2

Does what I proposed in comment 2. One issue is that we rely on all of content/dom/layout to have _IMPL_NS_LAYOUT defined for this to be effective, which is not the case. I made sure that all the directories where we use the DOMCI macro do have it set now.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 362097 [details] [diff] [review]
v2

Looks good. r+sr=jst