391485 - memory leak in nsToolkitProfileService::Flush

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Boying Lu]

Using memory leak detecting tool libumem.so on opensolaris as following:
1. export LD_PRELOAD=libumem.so
2. export UMEM_DEBUG=default
3. export LD_LIBRARY_PATH=dist/bin (full pathname of thunderbird-bin)
4. mdb ./thunderbird-bin 
5. ::run -P  (in mdb)

libumem.so will detect many memory leaks. one of them is a malloc() called in nsToolkitProfileService::Flush()

Comment 1

[Boying Lu]

Attachment: patch

Comment 2

[Boying Lu]

Attachment: patch

Comment 3

[Benjamin Smedberg]

Comment on attachment 275929 [details] [diff] [review]
patch

There are other paths out which could leak buffer... can you make buffer an autoclass intead?:

nsAutoArrayPtr<char> buffer = new char[100 + MAXPATHLEN * pCount];

Comment 4

[Boying Lu]

Attachment: use nsAutoArrayPtr<char>

Comment 5

[Benjamin Smedberg]

Comment on attachment 276072 [details] [diff] [review]
use nsAutoArrayPtr<char> 

Why did you need to put the declaration at the top, instead of when it's first used? Please change that unless there's a good reason.

Comment 6

[Boying Lu]

Attachment: move the declaration before the first use

Comment 7

[Benjamin Smedberg]

Comment on attachment 276729 [details] [diff] [review]
move the declaration before the first use

Still don't understand why you don't just declare it on the same line you use it, but this is ok.

Comment 8

[Boying Lu]

Attachment: combine the declaration and assignment in a line

Sorry for misunderstanding your point.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 276933 [details] [diff] [review]
combine the declaration and assignment in a line

a=bzbarsky

Comment 10

[:Gijs (he/him)]

Checking in mozilla/toolkit/profile/src/nsToolkitProfileService.cpp;
/cvsroot/mozilla/toolkit/profile/src/nsToolkitProfileService.cpp,v  <--  nsToolkitProfileService.cpp
new revision: 1.17; previous revision: 1.16
done