Closed Bug 391546 Opened 17 years ago Closed 2 years ago

Tooltip text color is incorrect

Categories

(Core :: Widget: Win32, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: robarnold, Assigned: robarnold)

Details

(Keywords: polish)

Attachments

(2 obsolete files)

We should query this from the theme if possible.
Assignee: nobody → robarnold
Attached patch Proposed solution (obsolete) — Splinter Review
Attachment #276569 - Flags: review?(vladimir)
Comment on attachment 276569 [details] [diff] [review]
Proposed solution

Looks good to me
Attachment #276569 - Flags: review?(vladimir) → review+
Attached patch Cleans up code (obsolete) — Splinter Review
I couldn't find a way to query the gradient color of the tooltips, but dark gray on yellow isn't that much different than black on yellow
Attachment #276569 - Attachment is obsolete: true
Attachment #277108 - Flags: review?(vladimir)
Hey Rob, we're you planning on landing this?
Comment on attachment 277108 [details] [diff] [review]
Cleans up code

This patch is bitrotted but probably still correct.
Attachment #277108 - Attachment is obsolete: true

This seems to work correctly now, although we don't seem to switch tooltips to dark mode when the system is in dark mode. I will open a bug if I can't find one.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: