391577 - fprintf bug in AvmDebugUnix.cpp

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Jason Orendorff [:jorendorff]]

gcc warns about it:

src/tamarin/tamarin-central/core/AvmDebugUnix.cpp: In function 'void avmplus::AvmDebugMsg(const avmplus::wchar*, bool)':
src/tamarin/tamarin-central/core/AvmDebugUnix.cpp:67: warning: format '%s' expects type 'char*', but argument 3 has type 'const avmplus::wchar*'

I think gcc is right, "%s" should be "%ls" on that line.

(On Mac OS, at least, this breaks the xp build, which uses -Werror.)

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I don't think %ls is portable; you may just want to either convert to UTF8, or, if this is just debugging code, just chop the high byte and convert to ascii.

Comment 2

[Jason Orendorff [:jorendorff]]

It might be worth changing it to %ls, checking that in, and then leaving this bug open (or filing a new one) because of the portability problem.  Being able to build is good.  :)

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: v1

Now I get this on the Mac as well.  The build is broken in actionmonkey branch because of this bug.

avmplus::wchar is not wchar_t, so %ls doesn't work.  So the patch converts to UTF-8 using UnicodeUtils.

There were Windows newlines in the file; this removes them.

Comment 4

[Dan Smith]

r+ to this change. 

Comment 5

[Jason Orendorff [:jorendorff]]

Attachment: v1a - check for null

Here's the version I'm checking in.  v1 didn't check for "new uint8[]" returning NULL, so I added that.

Comment 6

[Chris Peyer]

Transfer Bug from Core->Tamarin to Tamarin Product.